Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dataflow expiration for materialized views with REFRESH #29971

Closed
wants to merge 7 commits into from
Closed

Support dataflow expiration for materialized views with REFRESH #29971

wants to merge 7 commits into from

Conversation

sdht0
Copy link
Contributor

@sdht0 sdht0 commented Oct 11, 2024 •
edited
Loading

WIP.

Initial planning for eventual full support of MVs with non-default REFRESH schedules.

Fixes https://github.com/MaterializeInc/database-issues/issues/8646 https://github.com/MaterializeInc/database-issues/issues/8645

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@sdht0 sdht0 requested review from a team as code owners October 14, 2024 19:54
@sdht0 sdht0 requested a review from ParkMyCar October 14, 2024 19:54
@ggevay ggevay self-requested a review October 15, 2024 07:50
@sdht0 sdht0 force-pushed the replica-expiration-refresh-schedules branch from fc2feb2 to 868a917 Compare October 15, 2024 13:32
@sdht0 sdht0 marked this pull request as draft October 15, 2024 13:34
@sdht0 sdht0 force-pushed the replica-expiration-refresh-schedules branch from 0826dbf to 65970ae Compare October 16, 2024 02:47
@sdht0
Copy link
Contributor Author

sdht0 commented Oct 28, 2024

Reworked in #30162.

@sdht0 sdht0 closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParkMyCar ParkMyCar Awaiting requested review from ParkMyCar ParkMyCar is a code owner automatically assigned from MaterializeInc/adapter

@ggevay ggevay Awaiting requested review from ggevay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sdht0