-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[optimizer] report per-transform metrics #30806
[optimizer] report per-transform metrics #30806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapter changes LGTM
…me everything appropriately
MitigationsCompleting required mitigations increases Resilience Coverage.
Risk Summary:The pull request has a high risk score of 80, driven by predictors such as the "Sum Bug Reports Of Files" and "Delta of Executable Lines." Historically, PRs with these predictors are 115% more likely to cause a bug compared to the repository baseline. Although the observed and predicted bug trends in the repository are both decreasing, the presence of one file hotspot suggests a need for careful review. Note: The risk score is not based on semantic analysis but on historical predictors of bug occurrence in the repository. The attributes above were deemed the strongest predictors based on that history. Predictors and the score may change as the PR evolves in code, time, and review activity. Bug Hotspots:
|
Adds metrics for per-transform information (how often did the transform fire? how often did it change the AST?); enrich the end-to-end optimization time metric to add log-lines with per-transform timing information, which should aid in debugging.
Designed with advice from @antiguru.
Motivation
https://github.com/MaterializeInc/database-issues/issues/8764
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.