Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only decode rows up to demand #30808

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

antiguru
Copy link
Member

Decode rows in rendering up to a demand limit.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@antiguru antiguru requested a review from a team as a code owner December 12, 2024 17:54
@antiguru
Copy link
Member Author

Alright, this doesn't work as-is. In a lot of places, we evaluate an mfp, which assumes input_arity columns, and this change modifies the input_arity, without actually updating it.

Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
@ggevay
Copy link
Contributor

ggevay commented Dec 18, 2024

Converting to draft, as there are some test failures, and @antiguru said he is not planning to work on this in the near future. (I might pick it up if I have time.)

@ggevay ggevay marked this pull request as draft December 18, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants