-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add meson build #3
build: Add meson build #3
Conversation
This simplifies the installation of necessary data files for the thumbnailer to work, working around this long-standing RFE: rust-lang/cargo#2729 Ideally, meson would also be used to compile the binary instead of Cargo, but meson doesn't easily support external crates: mesonbuild/meson#2173
When this lands, I can retire |
Hi, I will look into this over this weekend.
Apparently gnome-nds-thumbnailer got removed from Fedora a while ago... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unsure on how to integrate this with the RPM spec.
Sure, I might be able to run some macro that triggers meson (not sure which yet) and that will save me from having to manually call install
to install the .thumbnailer file and the mime types. But will that still keep the licenses generation macros working?
Also it seems that the meson file calls the update mime database command unconditionally, which is fine if it's only used for manual installing, but it could be a problem if I want to integrate with the spec, as the mime type database update will be triggered on user's system automatically.
As it needs to be disabled for the installation process when building distribution packages.
About 18 months ago, not certain why.
meson just runs cargo. We could also make meson generate You can use:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though I would initially expect update_mime_database
to be opt-in instead of opt-out.
But, since we only don't want to do it for packaging, I think it makes sense to be opt-out.
From a search on the Fedora Devel list apparently they were removing inactive packages and orphaning their packages, and it seems gnome-nds-thumbnailer got caught into this, see here.
Makes sense, I will tag a new release soonish and then update the spec and update the COPR.
I believe that this means that you plan to archive the gnome-nds-thumbnailer repo, right? It could be a good idea to link to this repo and mention that it not only covers Nintendo DS .nds files but also several Nintendo 3DS file formats as well. Mentioning that it's written in Rust is optional. |
This simplifies the installation of necessary data files for the thumbnailer to work, working around this long-standing RFE: rust-lang/cargo#2729
Ideally, meson would also be used to compile the binary instead of Cargo, but meson doesn't easily support external crates: mesonbuild/meson#2173