Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dl margin space to match vspace length #1069

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

rocky
Copy link
Member

@rocky rocky commented Aug 13, 2024

Looking at the grey margin space around definition lists, it is still a little too large. 0.6em matches the vspace.

Somewhere I read a design principle that one should try reduce the overall number of different kinds of spacing.

Looking at the grey margin space around definition lists, it is still a
little too large. 0.6em matches the vspace.

Somewhere I read a design principle that one should try reduce the
overall number of different kinds of spacing.
@rocky rocky requested a review from mmatera August 13, 2024 10:50
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rocky, I trust you. LGTM

@rocky rocky merged commit 222b686 into master Aug 13, 2024
10 checks passed
@rocky rocky deleted the reduce-margin-in-dl branch August 13, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants