-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc tweaks... #1072
Misc tweaks... #1072
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,10 +42,10 @@ def compare(self, mathics_expr, sympy_expr, **kwargs): | |
self.compare_to_mathics(mathics_expr, sympy_expr) | ||
|
||
def testSymbol(self): | ||
self.compare(Symbol("Global`x"), sympy.Symbol("_Mathics_User_Global`x")) | ||
self.compare(Symbol("Global`x"), sympy.Symbol("_mg`x")) | ||
self.compare( | ||
Symbol("_Mathics_User_x"), | ||
sympy.Symbol("_Mathics_User_System`_Mathics_User_x"), | ||
Symbol("_mu_x"), | ||
sympy.Symbol("_mu`x"), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would expect that if the conversion routines haven't changed, and the prefix is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See above. Not sure why testing works when it shouldn't. Testing is probably a bit weak then. The issue of shortening context prefixes will be addressed in a more isolated PR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good. Then let's merge this when you feel it is ready. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The reason why the tests are "weak" is that we are not checking the result of the comparison. I will put a fix for this in another PR. |
||
) | ||
|
||
def testReal(self): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rocky, in the test it seems you used
_mu_
as the prefixThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I am reverting these changes for now, since I forget to update the testing. And the testing isn't catching the change either.
So all of this is more involved. I don't want to hold up other stuff because of these issues. Instead, I'll punt for now.