Add event handler #1074
Merged
Add event handler #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
do you mean the unit test? |
mmatera
approved these changes
Aug 27, 2024
| ) | ||
| self.compare( | ||
| Expression(SymbolGamma, Symbol("Global`z"), Symbol("Global`x")), | ||
| sympy.uppergamma( | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
This is a failure in merging, isn't it?
There was a problem hiding this comment.
That was later addressed using the unit test version in master without any changes.
Because there are substantive changes now in the failure, I suspect there is a deeper problem and something that needs conversion (or we need to use the prefix variables substitutions more).
rocky
force-pushed
the
add_event-handler
branch
2 times, most recently
from
5650345
to
0a464cd
Compare
start with running SymPy and mpmath functions.
This follows the pattern run_sympy
And add "debugger" event name. Possibly the tracing event names should get moved to Debugger.
test doesn't work though...
* Correct and expand comment regarding trace.run_xxx * And one other comment in trace_fn_call_event
rocky
force-pushed
the
add_event-handler
branch
from
0a464cd
to
a801896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code in support of event tracing debugging.
Used b y Mathics3 Module pymtathics.debugger in repository Mathics3/mathics-debugger.