apply_rule -> apply_function ... #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when that is what is is; (and not when it is not). Also mark BaseRule an abstract class, and go over docstrings in mathics.core.rules
|
Haven't heard back one way or another on this, so merging. We can adjust down the line. |
|
@rocky, sorry for the delay. In any case, I agree with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
apply_rule()-> toapply_function()when that is what is is; (and not when it is not).Also mark BaseRule an abstract class, and go over docstrings in mathics.core.rules
@mmatera I think i now understand what you were getting at when we were discussion replacement name for
do_replace(). Both functions are definitely apply functions. We could call the methodapply(). I think though being specific and explicit increases clarity and reduces potential confusion.