Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListStepPlot refactor _ListPlot a little #1096

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Add ListStepPlot refactor _ListPlot a little #1096

merged 5 commits into from
Sep 27, 2024

Conversation

rocky
Copy link
Member

@rocky rocky commented Sep 26, 2024

  • Add ListStepPlot[]
  • Refactor _ListPlot[] a little; note this is an abstract class. Add a ListPlot type enum
  • mathics.eval.plot -> mathics.eval.drawing.plot

@rocky rocky requested a review from mmatera September 26, 2024 22:51
@rocky
Copy link
Member Author

rocky commented Sep 26, 2024

As always, this is not perfect; not all options are supported. But it is a starting point.

@rocky rocky force-pushed the add-ListStepPlot branch 2 times, most recently from 37df862 to 9d6b87e Compare September 26, 2024 23:02
Revise docstring in mathics.eval.drawing.plot.eval_ListPlot
@@ -2067,14 +2067,16 @@ class ListStepPlot(_ListPlot):
>> ListStepPlot[{1, 1, 2, 3, 5, 8, 13, 21}]
= -Graphics-


By default ListStepPlots are joined, but that can be disabled.
'ListPlot' accepts a superset of the Graphics options. \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be 'ListStepPlot'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - corrected now.

Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky merged commit 8e0aff8 into master Sep 27, 2024
11 checks passed
@rocky rocky deleted the add-ListStepPlot branch September 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants