Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional changes to: bark if builtin rule cannot be stored. #1119

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Additional changes to: bark if builtin rule cannot be stored. #1119

merged 4 commits into from
Oct 3, 2024

Conversation

rocky
Copy link
Member

@rocky rocky commented Oct 3, 2024 •
edited
Loading

Code review of #1006

@rocky rocky requested a review from mmatera October 3, 2024 15:50
@rocky rocky marked this pull request as draft October 3, 2024 15:51
@rocky rocky changed the title check_is_subvalue() -> is_pattern_a_kind_of() ... Additional changes to: bark if builtin rule cannot be stored. Oct 3, 2024
mmatera
mmatera approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky marked this pull request as ready for review October 3, 2024 20:51
@rocky rocky merged commit b7559d8 into bark_if_builtin_rule_cannot_be_stored Oct 3, 2024
8 checks passed
@rocky rocky deleted the bark_if_builtin_rule_cannot_be_stored-more branch October 3, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatera mmatera mmatera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocky @mmatera