Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set ops another round #605

Closed
wants to merge 13 commits into from
Closed

Fix set ops another round #605

wants to merge 13 commits into from

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Nov 10, 2022

With this PR, that comes after #601, #602, #603 and #604, allows to load the mymakeboxes.m package, and hopefully, should help to load other packages like KnotTheory, Feyncalc and others.

@rocky
Copy link
Member

rocky commented Nov 10, 2022

@mmatera - This is and #601 to #604 are interesting and I would like to go through these and understand in more detail. I haven't had the time to do so, but will very soon. Thanks for doing this.

I am excited to hear that Mathics package loading may now be fixed. This is very important.

Removing lines that break this together with DisplayForm
Remove useless blank
@rocky
Copy link
Member

rocky commented Nov 13, 2022

With this PR, that comes after #601, #602, #603 and #604,

Does this really depend on #604? At any rate perhaps the merge branch should be #603 (or #604) instead of master. If either of these lands onto master, then this can be merged to master directly. What we've seen is that when there are lot of changes to the dependent branches (and PRs here have to go in the order they were done), then we are likely to create merge conflicts here where none were needed.

@mmatera
Copy link
Contributor Author

mmatera commented Nov 13, 2022

.

#604 and this are independent. What I was saying it that I need these PR to make mymakeboxes.m work.

@mmatera mmatera mentioned this pull request Nov 13, 2022
@mmatera
Copy link
Contributor Author

mmatera commented Nov 13, 2022

reformulated in #616 as a PR over #603

@mmatera mmatera closed this Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants