Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaves->elements & Makefile... #644

Merged
merged 1 commit into from
Nov 26, 2022
Merged

leaves->elements & Makefile... #644

merged 1 commit into from
Nov 26, 2022

Conversation

rocky
Copy link
Member

@rocky rocky commented Nov 26, 2022

  • Correct one more incorrect use of leaves.
  • In pytest be explicit about character encoding

The first change is split off from #639 .
The second change is split off from #631. With that change some tests attempt to start using the unicode symbols, presumably because some MakeBox rules are no longer wiped out (or vice versa?). Either way this should be there.

Correct one more incorrect use of leaves.
In pytest be explicit about character encoding
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky merged commit 5a11bbf into master Nov 26, 2022
@rocky rocky deleted the elements-correction branch November 26, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants