Add complex expand #873
Merged
Add complex expand #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move code from django_doc and latex_doc .py to common_doc.py In the process we should handle pymathics better. Remove a number of unused functions and variables like ``is_private`` and pymathics_doc_loaded.
See if we can get by with out using the want_sorting parameter
Pull out flaky Unique[] doctests and start a more robust pytest for these. more work is needed.
Fix bug in InterpretedBox
Reinstate hard-coded XMLDoc where self.doc_fn() is not available Reinstante want_sorting option
--pymathics -> --load-module. Note that one splits module names with a comma. The name Pymathics is deprecated
Clean up ComplexExpand Added test cases for ComplexExpand Fix style
Implement ComplexExpand
|
One very small thing that was missing from ComplexExpand is to mention it in CHANGES.rst. And there was the duplication of the same expression as a doctest and a pytest. There are problem a lot more examples that could be tried - if they are of interest to users then a statement of what aspect this is showing interesting would be in the doctest. (I think that is missing in the current doctest that I started). Or if it is just an edge case that we want to test then it would go in pytest. I will try to look at it more detail late today. |
* Correct behavior when only one complex variable has been given * Add "ComplexExpand" to CHANGES.rst * More ComplexExpand doctests * Correct url links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rocky, I open this PR to avoid losing the last changes. I think it is almost ready, but I put this as a draft in case you think there are pending things.