Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring lru #896

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Restoring lru #896

merged 3 commits into from
Aug 2, 2023

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Aug 2, 2023

I did this before, but for some reason it wasn´t merged...

# In Python, and mpmath, `0.j` and `0.` equivalent, in the sense
# that are considered equal numbers, and have the same associated
# hash.
# In WMA, this is not the case. To produce recover the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the word "recover"

@@ -42,6 +42,13 @@ def from_mpmath(
# HACK: use str here to prevent loss of precision
return PrecisionReal(sympy.Float(str(value), precision=precision - 1))
elif isinstance(value, mpmath.mpc):
# Comment mmatera:
# In Python, and mpmath, `0.j` and `0.` equivalent, in the sense
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

equivalent -> are equivalent

@rocky
Copy link
Member

rocky commented Aug 2, 2023

Small English grammar things. LGTM.

grammar fixes
@mmatera mmatera merged commit eb30221 into master Aug 2, 2023
11 checks passed
@mmatera mmatera deleted the restoring_lru branch August 2, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants