Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathicsSession.evaluate_as_in_cli #931

Merged
merged 6 commits into from
Jan 16, 2024
Merged

MathicsSession.evaluate_as_in_cli #931

merged 6 commits into from
Jan 16, 2024

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Oct 17, 2023

This PR implements a method in the MathicsSession class that uses the Evaluation.evaluate method. This allows to handle exceptions and special symbols like % or Line references. This method is used in certain pytests.

TODO: define a better name for the method and improve docstrings...

… Evaluation.evaluate method. This allows to handle exceptions and special symbols like % or Line references. This method is used in certain pytests.
@rocky
Copy link
Member

rocky commented Dec 17, 2023

I can't think of a better name. And this is an improvement on what we currently have: adds some docstrings and and removes some . So +1 for adding.

@mmatera mmatera marked this pull request as ready for review December 21, 2023 00:03
@mmatera mmatera merged commit dc4c436 into master Jan 16, 2024
11 checks passed
@mmatera mmatera deleted the evaluation_as_in_cli branch January 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants