Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RPC handler to touch files #820

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from
Draft

Conversation

aryanjassal
Copy link
Contributor

@aryanjassal aryanjassal commented Oct 1, 2024

Description

This PR implements a RPC handler which touches files. Touching a file means that a file must be created if it doesn't exist, or update its access/modification timestamps to current time if it does.

Most likely Polykey#821 needs to be finished before this can be done.

Issues Fixed

Tasks

  • 1. Create a VaultsSecretsTouch RPC handler
  • 2. Create files if they don't exist, update timestamps if they do
  • 3. Add support for doing so for multiple vaults in a single commit
  • 4. Add vaultOps.touchFile (or just do it manually in the handler)
  • 5. Write tests for VaultsSecretsTouch
  • 6. Write tests for vaultOps.touchFile (if it exists)

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@aryanjassal aryanjassal self-assigned this Oct 1, 2024
Copy link

linear bot commented Oct 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant