Adding RPC handler to touch files
#820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryanjassal
force-pushed
the
feature-unix-touch
branch
from
8515532 to
6639429
Compare
|
In order to perform operations across vaults in a single commit, I will be re-using the header-content protocol developed during work on a similar issue for First, a header message containing all the vault names will be sent, so a resource can be acquired for them all ahead of time. Then, each content message will perform all its actions within a single commit message in the vaults side. |
aryanjassal
force-pushed
the
feature-unix-touch
branch
from
6639429 to
06d3f0d
Compare
|
I will now work on the command from Polykey CLI |
aryanjassal
force-pushed
the
feature-unix-touch
branch
from
35bf5fd to
5a6b3a7
Compare
|
The CI is passing for this, and the tests I performed in PKCLI are also working, so the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a RPC handler which touches files. Touching a file means that a file must be created if it doesn't exist, or update its access/modification timestamps to current time if it does.
Most likely Polykey#821 needs to be finished before this can be done.
Issues Fixed
Tasks
VaultsSecretsTouchRPC handlervaultOps.touchFile(or just do it manually in the handler)VaultsSecretsTouchvaultOps.touchFile(if it exists)Final checklist