Add cancellation to RPC handlers #846
Conversation
|
For each RPC handler, we need to provide a Should I make a commit into |
|
Don't bother defining the type for it unless you're actually using it. So you can just name the |
I just did this to mute the warnings for type hints, as TS assumes it is |
| const commits = new Set<string>(); | ||
| const trees = new Set<string>(); | ||
| const blobs = new Set<string>(); | ||
| const tags = new Set<string>(); | ||
| const havesSet: Set<string> = new Set(haves); | ||
|
|
||
| async function walk(objectId: ObjectId, type: ObjectType): Promise<void> { | ||
| // ctx.signal.throwIfAborted(); | ||
| // If object was listed as a have then we don't need to walk over it | ||
| if (havesSet.has(objectId)) return; | ||
| switch (type) { |
There was a problem hiding this comment.
This method is used in VaultInternal in garbageCollectGitObjects, which is called when initialising VaultInternal. As such, we don't have access to a context. Should I manually create a context and pass it in, or make context an optional parameter here?
There was a problem hiding this comment.
You'll need to pass the ctx to whatever needs it. For public methods in a class you should use the @timedCancellable decorator. Look at other cancellable methods for reference. For internal methods you can just pass along the ctx.
Description
Without proper abortion or cancellation for a RPC, it will keep running and conclude first. This ends up adding a significant amount of time when closing the agent, as all outstanding RPC calls must resolve beforehand.
Issues Fixed
Tasks
AgentLockAllAgentStatusAgentStopAgentUnlockAuditEventsGetAuditMetricGetGestaltsActionsGetByIdentityGestaltsActionsGetByNodeGestaltsActionsSetByIdentityGestaltsActionsSetByNodeGestaltsActionsUnsetByIdentityGestaltsActionsUnsetByNodeGestaltsDiscoveryByIdentityGestaltsDiscoveryByNodeGestaltsDiscoveryQueueGestaltsGestaltsGetByIdentityGestaltsGestaltsGetByNodeGestaltsGestaltsListGestaltsGestaltsTrustByIdentityGestaltsGestaltsTrustByNodeIdentitiesAuthenticateIdentitiesAuthenticatedGetIdentitiesClaimIdentitiesInfoConnectedGetIdentitiesInfoGetIdentitiesInviteIdentitiesProvidersListIdentitiesTokenDeleteIdentitiesTokenGetIdentitiesTokenPutKeysCertsChainGetKeysCertsGetKeysDecryptKeysEncryptKeysKeyPairKeysKeyPairRenewKeysKeyPairResetKeysPasswordChangeKeysPublicKeyKeysSignKeysVerifyNodesAddNodesClaimNodesFindNodesGetAllNodesListConnectionsNodesPingNotificationsInboxClearNotificationsInboxReadNotificationsInboxRemoveNotificationsOutboxClearNotificationsOutboxClearNotificationsOutboxReadNotificationsOutboxRemoveNotificationsSendVaultsCloneVaultsCreateVaultsDeleteVaultsListVaultsLogVaultsPermissionGetVaultsPermissionSetVaultsPermissionUnsetVaultsPullVaultsRenameVaultsScanVaultsSecretsCatVaultsSecretsEnvVaultsSecretsGetVautlsSecretsListVaultsSecretsMkdirVaultsSecretsNewVaultsSecretsNewDirVaultsSecretsRemoveVaultsSecretsRenameVaultsSecretsStatVaultsSecretsWriteFileVaultsVersionFinal checklist