Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: merge staging to master #27

Merged
merged 38 commits into from
Jul 6, 2023
Merged

ci: merge staging to master #27

merged 38 commits into from
Jul 6, 2023

Conversation

MatrixAI-Bot
Copy link
Member

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

@MatrixAI-Bot MatrixAI-Bot self-assigned this May 23, 2023
@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 875354228 for 3747725

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/875354228

@ghost
Copy link

ghost commented May 23, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 876804008 for dd13f2c

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/876804008

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 876841763 for e853e94

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/876841763

@MatrixAI-Bot
Copy link
Member Author

Pipeline Succeeded on 876841763 for e853e94

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/876841763

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 876877914 for 7dfcfbd

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/876877914

@MatrixAI-Bot
Copy link
Member Author

Pipeline Succeeded on 876877914 for 7dfcfbd

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/876877914

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 876914462 for 9079f97

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/876914462

@MatrixAI-Bot
Copy link
Member Author

Pipeline Succeeded on 876914462 for 9079f97

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/876914462

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 911343211 for ac6ddc0

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/911343211

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 911343224 for 286a006

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/911343224

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 911496818 for e019bcd

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/911496818

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 912531327 for 5693ef8

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/912531327

tegefaulkes added 18 commits July 6, 2023 14:31
@tegefaulkes
fix: removing fixtures
b45cc22 
[ci skip]
@tegefaulkes
tests: fixing up tests
a2058cc 
[ci skip]
@tegefaulkes
dep: bump @matrixai/async-init to 1.8.4
1d55f12 
[ci skip]
@tegefaulkes
feat: added in secure establishment event
9f6ae63 
[ci skip]
@tegefaulkes
feat: added verifyCallback and verifyAllowFail
225babf 
[ci skip]
@tegefaulkes
tests: fixing up client tests
9cc653d 
- Fixed up start erroring out.
- Fixed up graceful TLS test.
- Cleaning up.

[ci skip]
@tegefaulkes
tests: creating native stream tests
110034d 
[ci skip]
@tegefaulkes
fix: small fixes
b1ea509 
[ci skip]
@tegefaulkes
feat: QUICConnection and QUICClient handles ctx and timeouts
6009eb2 
[ci skip]
@tegefaulkes
tests: adding custom TLS verification tests
cea873b 
[ci skip]
@tegefaulkes
feat: applying maxIdleTimeout constraints for keep-alive and start …
968ae89 
…timeout

[ci skip]
@tegefaulkes
tests: fixing up tests to match changes
85b0375 
- fixed up `QUICServer.test.ts`
- fixed up `QUICSocket.test.ts`
- fixed up `concurrency.test.ts`

[ci skip]
@tegefaulkes
lint: fixing up linting errors
798014b 
[ci skip]
@tegefaulkes
tests: expanding native stream tests
30daec8 
[ci skip]
@tegefaulkes
fix: refactored and cleaned up
242859c 
- cleaning up `QUICStream.ts` writable stream logic
- cleaning up `QUICStream.ts` readable stream logic
- fixing up `QUICStream` tests

[ci skip]
@tegefaulkes
fix: general logic fixes and clean up
ed6f3a3 
- logic fixes for early stream ending.
- fixing up tests.
- fixed up remote info for stream.
- fixed problem with process being held open and handling socket errors.
- propagating all events to the top level client or server.
- cleaning up comments and commentary.
- fixed up benchmark.
@tegefaulkes
fix: cleaning up Monitor resources
cbedc26
@tegefaulkes
Merge pull request #26 from MatrixAI/feature-key-gen
06bb0d9 
Review - Tests, Key and Certificate Generation, Concurrency Control, Custom TLS Verification
@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 922716923 for 06bb0d9

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/922716923

@tegefaulkes
Copy link
Contributor

I fixed up the problem with the benchmark but there is a problem with the mac runner. The brew-install script is failing.

All the tests are succeeding in the Linux runner. So that's good.

@CMCDragonkai
Copy link
Member

Can you check what's going on with the mac runner compare to js-db which is doing a native build. Compare the CI yaml files as well as the scripts.

@CMCDragonkai
Copy link
Member

Check with #24 too to see if windows still has the same problem, upstream seems to still have the same issue with others reporting.

@CMCDragonkai
Copy link
Member

Don't forget to check if docs build works too.

@CMCDragonkai
Copy link
Member

Please note that the CI here will need to push up multiple NPM packages... since we are using optional dependencies now.

@MatrixAI-Bot
Copy link
Member Author

Pipeline Attempt on 922781592 for 3157537

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/922781592

@MatrixAI-Bot
Copy link
Member Author

Pipeline Succeeded on 922781592 for 3157537

https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/922781592

@MatrixAI-Bot MatrixAI-Bot merged commit 3157537 into master Jul 6, 2023
@CMCDragonkai
Copy link
Member

Build succeeded. @tegefaulkes make sure to look into addressing:

@tegefaulkes
Copy link
Contributor

In terms of raw data flow the benchmark seems pretty slow. But it is creating and closing a stream each op so that would be slow. Just writing data should be a fair bit quicker. If it's a problem there are some optimisations that can be made.

  1. We need to reduce the amount of work done when moving data around. So the less function calls and work done when processing reads and writes the better. The monitors could be a major factor in this but we'll need to bench with and without them to be sure.
  2. When it comes to network code, one of the main ways to improve it's speed is to reduce the number of kernel elevations done. That's every time we read or write to the socket. But since we're using the node dgram module here I'm not sure what can be done. I think the only option is to send multiple messages to a single destination at once. Normally a socket will allow you to send multiple messages to multiple destinations all in one send.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MatrixAI-Bot MatrixAI-Bot

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatrixAI-Bot @tegefaulkes @CMCDragonkai