Events Refactoring (integrating js-events)

.eslintrc

@@ -39,6 +39,12 @@
         "message": "Use `globalThis` instead"
       }
     ],
+    "prefer-rest-params": 0,
+    "prefer-const": [
+      "error", {
+        "destructuring": "all"
+      }
+    ],
     "require-yield": 0,
     "eqeqeq": ["error", "smart"],
     "spaced-comment": [

.npmignore

@@ -10,6 +10,7 @@
 /tests
 /tmp
 /docs
+/images
 /benches
 /build
 /builds

Cargo.toml

@@ -14,8 +14,8 @@ path = "src/native/napi/lib.rs"
 napi = { version = "2", features = ["async", "napi6", "serde-json"] }
 serde = { version = "1.0", features = ["derive"] }
 napi-derive = { version = "2", default-features = false, features = ["strict", "compat-mode"] }
-quiche = { version = "0.17.1", features = ["boringssl-boring-crate", "boringssl-vendored"] }
-boring = "2.1.0"
+quiche = { version = "0.18.0", features = ["boringssl-boring-crate", "boringssl-vendored"] }
+boring = "3"
 
 [build-dependencies]
 napi-build = "2"

README.md

@@ -108,6 +108,57 @@ x86_64-apple-darwin
 
 The available target list is in `rustc --print target-list`.
 
+### Structure
+
+It is possible to structure the QUIC system in the encapsulated way or the injected way.
+
+When using the encapsulated way, the `QUICSocket` is separated between client and server.
+
+When using the injected way, the `QUICSocket` is shared between client and server.
+
+![](/images/quic_structure_encapsulated.svg)
+
+If you are building a peer to peer network, you must use the injected way. This is the only way to ensure that hole-punching works because both the client and server for any given peer must share the same UDP socket and thus share the `QUICSocket`. When done in this way, the `QUICSocket` lifecycle is managed outside of both the `QUICClient` and `QUICServer`.
+
+![](/images/quic_structure_injected.svg)
+
+This also means both `QUICClient` and `QUICServer` must share the same connection map.  In order to allow the `QUICSocket` to dispatch data into the correct connection, the connection map is constructed in the `QUICSocket`, however setting and unsetting connections is managed by `QUICClient` and `QUICServer`.
+
+## Dataflow
+
+The data flow of the QUIC system is a bidirectional graph.
+
+Data received from the outside world is received on the UDP socket. It is parsed and then dispatched to each `QUICConnection`. Each connection further parses the data and then dispatches to the `QUICStream`. Each `QUICStream` presents the data on the `ReadableStream` interface, which can be read by a caller.
+
+Data sent to the outside world is written to a `WritableStream` interface of a `QUICStream`. This data is buffered up in the underlying Quiche stream. A send procedure is triggered on the associated `QUICConnection` which takes all the buffered data to be sent for that connection, and sends it to the `QUICSocket`, which then sends it to the underlying UDP socket.
+
+![](/images/quic_dataflow.svg)
+
+Buffering occurs at the connection level and at the stream level. Each connection has a global buffer for all streams, and each stream has its own buffer. Note that connection buffering and stream buffering all occur within the Quiche library. The web streams `ReadableStream` and `WritableStream` do not do any buffering at all.
+
+### Connection Negotiation
+
+The connection negotiation process involves several exchanges of QUIC packets before the `QUICConnection` is constructed.
+
+The primary reason to do this is for both sides to determine their respective connection IDs.
+
+![](/images/quic_connection_negotiation.svg)
+
+### Push & Pull
+
+The `QUICSocket`, `QUICClient`, `QUICServer`, `QUICConnection` and `QUICStream` are independent state machines that exposes methods that can be called as well as events that may be emitted between them.
+
+This creates a concurrent decentralised state machine system where there are multiple entrypoints of change.
+
+Users may call methods which causes state transitions internally that trigger event emissions. However some methods are considered internal to the library, this means these methods are not intended to be called by the end user. They are however public relative to the other components in the system. These methods should be marked with `@internal` documentation annotation.
+
+External events may also trigger event handlers that will call methods which perform state transitions and event emission.
+
+Keeping track of how the system works is therefore quite complex and must follow a set of rules.
+
+* Pull methods - these are either synchronous or asynchronous methods that may throw exceptions.
+* Push handlers - these are event handlers that can initiate pull methods, if these pull handlers throw exceptions, these exceptions must be caught, and expected runtime exceptions are to be converted to error events, all other exceptions will be considered to be software bugs and will be bubbled up to the program boundary as unhandled exceptions or unhandled promise rejections. Generally the only exceptions that are expected runtime exceptions are those that arise from perform IO with the operating system.
+
 ## Benchmarks
 
 ```sh

benches/index.ts

@@ -1,35 +1,43 @@
 #!/usr/bin/env ts-node
 
+import type { Summary } from 'benny/lib/internal/common-types';
 import fs from 'fs';
 import path from 'path';
 import si from 'systeminformation';
-import Stream1KB from './stream_1KB';
+import { fsWalk, resultsPath, suitesPath } from './utils';
 
 async function main(): Promise<void> {
   await fs.promises.mkdir(path.join(__dirname, 'results'), { recursive: true });
-  // Running benches
-  await Stream1KB();
-  const resultFilenames = await fs.promises.readdir(
-    path.join(__dirname, 'results'),
-  );
-  const metricsFile = await fs.promises.open(
-    path.join(__dirname, 'results', 'metrics.txt'),
-    'w',
-  );
+  // Running all suites
+  for await (const suitePath of fsWalk(suitesPath)) {
+    // Skip over non-ts and non-js files
+    const ext = path.extname(suitePath);
+    if (ext !== '.ts' && ext !== '.js') {
+      continue;
+    }
+    const suite: () => Promise<Summary> = (await import(suitePath)).default;
+    // Skip default exports that are not functions and are not called "main"
+    // They might be utility files
+    if (typeof suite === 'function' && suite.name === 'main') {
+      await suite();
+    }
+  }
+  // Concatenating metrics
+  const metricsPath = path.join(resultsPath, 'metrics.txt');
+  await fs.promises.rm(metricsPath, { force: true });
   let concatenating = false;
-  for (const resultFilename of resultFilenames) {
-    if (/.+_metrics\.txt$/.test(resultFilename)) {
-      const metricsData = await fs.promises.readFile(
-        path.join(__dirname, 'results', resultFilename),
-      );
-      if (concatenating) {
-        await metricsFile.write('\n');
-      }
-      await metricsFile.write(metricsData);
-      concatenating = true;
+  for await (const metricPath of fsWalk(resultsPath)) {
+    // Skip over non-metrics files
+    if (!metricPath.endsWith('_metrics.txt')) {
+      continue;
+    }
+    const metricData = await fs.promises.readFile(metricPath);
+    if (concatenating) {
+      await fs.promises.appendFile(metricsPath, '\n');
     }
+    await fs.promises.appendFile(metricsPath, metricData);
+    concatenating = true;
   }
-  await metricsFile.close();
   const systemData = await si.get({
     cpu: '*',
     osInfo: 'platform, distro, release, kernel, arch',
@@ -41,4 +49,8 @@ async function main(): Promise<void> {
   );
 }
 
-void main();
+if (require.main === module) {
+  void main();
+}
+
+export default main;