Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added refresh and reset methods #6

Merged
merged 2 commits into from
Mar 15, 2023
Merged

feat: added refresh and reset methods #6

merged 2 commits into from
Mar 15, 2023

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Mar 14, 2023 •
edited
Loading

Description

This adds the refresh and reset features to the timer.

Issues Fixed

Tasks

  • 1. Add refresh and reset features.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Mar 14, 2023
@ghost
Copy link

ghost commented Mar 14, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@tegefaulkes
Copy link
Contributor Author

I can merge now or I can add in the errors which is a little annoying since Timer doesn't throw any errors already so I'd have to create them from scratch.

@tegefaulkes
fix: refresh and reset throws when timer has ended
65761b1 
Also added in `@matrixai/errors`.
@tegefaulkes tegefaulkes merged commit 6632436 into staging Mar 15, 2023
@CMCDragonkai
Copy link
Member

This has a bug in it. The @/errors is being used in Timer.ts. This has broken downstream packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tegefaulkes tegefaulkes

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: support timer refresh and reset
2 participants
@tegefaulkes @CMCDragonkai