Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure for features #36

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Structure for features #36

wants to merge 5 commits into from

Conversation

mani1232
Copy link
Contributor

Initiation

@mani1232
Copy link
Contributor Author

#30

@mani1232
Copy link
Contributor Author

It's a lot of work)
image

@Matt-MX
Copy link
Owner

Matt-MX commented Jun 28, 2024

I think some of the core stuff could do with a refactor tbh, it also needs more JavaDocs since I always add something then forget to document.

If possible try and retain the method signatures so existing plugins using it don't need to be updated (too much)

@mani1232 mani1232 changed the title Setup for support other platforms Structure for features Jul 17, 2024
@mani1232
Copy link
Contributor Author

mani1232 commented Jul 17, 2024

@Matt-MX
There's a lot of work to add Spigot support, I can't do it, and I don't need it already.
But I'm going to do com.mattmx:ktgui-[feature]:[version]
Examples:

com.mattmx:ktgui-config-core:
com.mattmx:ktgui-config-json:
com.mattmx:ktgui-config-yaml:

com.mattmx:ktgui-gui:

com.mattmx:ktgui-commands:

etc.

@Matt-MX
Copy link
Owner

Matt-MX commented Jul 18, 2024

Yeah I was gonna say it's a big job to abstract this all but that sounds good man 👍

@mani1232
Copy link
Contributor Author

@Matt-MX

3 questions

  1. Im think about dropping protocollib and use https://github.com/retrooper/packetevents
  2. Drop 1.20 and every old version? and use latest version (now 1.21)
  3. Add support coroutines? Good feature but not very need

@Matt-MX
Copy link
Owner

Matt-MX commented Jul 28, 2024

packet-events is definately superior. However, we could really just get rid of the Anvil gui example since then we don't need protocollib or packet events. That's literally all ProtocolLib is there for in the first place.

I'd like to keep support for 1.20.4+ since my servers run on it. We can and should still upgrade to 1.21 since I'd like to add brigadier support for the declarative commands and some sort of holograms/interactions helper or wrapper.

I've never used coroutines and so haven't much understanding or experience working with them so my usage might cause unneeded issues and complications.

@Matt-MX
Copy link
Owner

Matt-MX commented Jul 28, 2024

I'll do a review of the changes made here later. I've also updated the dev branch to impl libs.versions.toml, paperweight and more.

@Matt-MX
Copy link
Owner

Matt-MX commented Dec 7, 2024

@mani1232

Refactoring with multi-platform support in consideration on the dev-platforms branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants