-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure for features #36
base: master
Are you sure you want to change the base?
Conversation
I think some of the core stuff could do with a refactor tbh, it also needs more JavaDocs since I always add something then forget to document. If possible try and retain the method signatures so existing plugins using it don't need to be updated (too much) |
@Matt-MX com.mattmx:ktgui-config-core: com.mattmx:ktgui-gui: com.mattmx:ktgui-commands: etc. |
Yeah I was gonna say it's a big job to abstract this all but that sounds good man 👍 |
3 questions
|
packet-events is definately superior. However, we could really just get rid of the I'd like to keep support for 1.20.4+ since my servers run on it. We can and should still upgrade to 1.21 since I'd like to add brigadier support for the declarative commands and some sort of holograms/interactions helper or wrapper. I've never used coroutines and so haven't much understanding or experience working with them so my usage might cause unneeded issues and complications. |
I'll do a review of the changes made here later. I've also updated the |
Refactoring with multi-platform support in consideration on the dev-platforms branch |
Initiation