Fix error in fallback method for check_abs_connection() (#248)

* look for method env var

* update DESC/NEWS; use method env var in check_abs_connection()

* refresh internal data

* use \describe rather than \itemize in docs for some reason

* update docs

* iterate version

* fix check_abs_connection()

* iterate ver

* go to 0.4.16

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: readabs
 Type: Package
 Title: Download and Tidy Time Series Data from the Australian Bureau of Statistics
-Version: 0.4.15
+Version: 0.4.16
 Authors@R: c(
            person("Matt", "Cowgill", role = c("aut", "cre"), email = "[email protected]", comment = c(ORCID = "0000-0003-0422-3300")),
            person("Zoe", "Meers", role = "aut", email = "[email protected]"),

NEWS.md

@@ -1,3 +1,7 @@
+
+# readabs 0.4.16
+* An error inadvertently introduced in 0.4.15 is fixed. This error would only affect a small minority of users.
+
 # readabs 0.4.15
 * read_lfs_datacube() convenience function added
 * New environment variable "R_READABS_DL_METHOD" can be set. When set, this is passed to the `method` argument of `download.file()`. Useful on networks where a method such as "wininet" must be used.

R/check_abs_connection.R

@@ -73,7 +73,7 @@ url_exists <- function(url = "https://www.abs.gov.au") {
 #' @noRd
 url_exists_nocurl <- function(url = "https://www.abs.gov.au") {
   con <- url(url,
-             Sys.getenv("R_READABS_DL_METHOD", unset = "default"))
+             method = Sys.getenv("R_READABS_DL_METHOD", unset = "default"))
   out <- suppressWarnings(tryCatch(readLines(con), error = function(e) e))
   abs_url_works <- all(class(out) != "error")
   close(con)