Remove coerce to numeric from read_api #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2024 08:55
…aw read to class character and attempts to convert any column not in a codelits to numeric
|
Closes #249 |
|
Thanks so much @kletts |
MattCowgill
merged commit 9ddfc33
into
MattCowgill:dont_coerce_numeric_apidata
4 checks passed
MattCowgill
added a commit
that referenced
this pull request
Jun 9, 2024
* Remove coerce to numeric from read_api (#250) * column class treatment defaults for reading codelists: defaults the raw read to class character and attempts to convert any column not in a codelits to numeric * removed testing file --------- Co-authored-by: Christian Klettner <[email protected]> * iterate version * don't retain commented out code chunks * run styler::style_pkg() --------- Co-authored-by: Christian Klettner <[email protected]> Co-authored-by: Christian Klettner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matt,
Here's a pull request to update the code to address the issue #249.
I found that the source of the coercion was actually upstream in the initial read of the CSV in which the R function read.csv when column classes are not specific defaults to guessing.
Having adjusted the import of the CSV as character, the labelling function now attempts to coerce only the non-code columns as discussed in the issue.
Christian