-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read_erp function #261
read_erp function #261
Conversation
Thanks @fmarkham, will review when I can (hopefully this week) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## read_erp #261 +/- ##
===========================================
Coverage ? 88.37%
===========================================
Files ? 30
Lines ? 1351
Branches ? 0
===========================================
Hits ? 1194
Misses ? 157
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fmarkham this is fantastic! Thanks so much. I'm going to merge it into a branch, then add some unit tests, then go to master.
@fmarkham the output doesn't have an |
It was intentional as the motivating use case (get the population aged 18 plus by state and sex over time) doesn't require age in single years to be returned. But this is more general and perhaps in keeping with the style of Thanks for refactoring the code, learnt a few things looking at your edits :) |
As per issue 260, this pull request contains a function that simplifies accessing ERPs for states and territories by age group and sex. The motivating use case is to access ERPs for those aged 18 or over, which isn't published in an easily accessible series as far as I know.
I'm not an experienced package author, so you may wish to review the code.