Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert color profiles in JPEG into sRGB #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CatoTH
Copy link

@CatoTH CatoTH commented Dec 30, 2012

I encountered a problem with Adaptive Images when using it for Jpeg files that have an embedded color profile. The color profile is lost, as this seems to be not yet supported by the GD library, changing the displayed colors. The problem can be seen here: http://adaptive.hoessl.eu/ ; the upper image is the original, the lower one is converted image; the bright red color has changed into something rather brownish.
The only solution I found to this problem was to use an external programm to convert the images into sRGB; the proposed patch uses the program "jpegicc".

@decarola
Copy link

decarola commented Mar 5, 2013

Went into the same kind of problem. Do you think Matt Wilcox will add the jpegicc program into the default version of Adaptive-Images? Actually, did he reply to you?

@pudgereyem
Copy link

Just want to stay that I also have this problem with managing Color profiles.
Besides that, I also experienced that the images created with Adaptive Images gets pretty bad. If you compress the same image in Photoshop it's all good. I will file a separate issue for this probably.

Below are some comparisons for an image (2560 x 1707):

..the version that Adaptive outputs is half the size, but it looks really bad. Why? Ping @MattWilcox @CatoTH @decarola

@j-greig
Copy link

j-greig commented Jun 16, 2014

Same problem here.

This could also be fixed by enabling Imagick as an alternative to GD library, right?

(I'm using a Wordpress plugin (https://wordpress.org/plugins/imagemagick-engine/) for this, but obviously its images are being superseded by Adaptive Images')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants