This repository has been archived by the owner on May 22, 2019. It is now read-only.
Add support for arrays in events and results in the client #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no issue sending lists and arrays in results or events but the client only takes the first element of the returned list as it is hardcoded.
Handling Iterables needs a new API as internal class gets deleted the due to type erasure and you end with a list/set of JsonNodes. We will need to add a new call or subscribe api that uses a TypeReference to properly support that, that leads to more changes in the internal code, so I left that for a future improvement.
Handling arrays is as simple as just letting the jackson parse all the elements received in the response so I added support for it.