Python 3 #5
Python 3 #5
Conversation
There was a problem hiding this comment.
I think this repo should be updated to follow https://www.taurus-scada.org/devel/plugins.html
I also propose that we move it to gitlab.com. I can do that and we can continue the discussion on the MR there?
That would allow to add a .gitlab-ci.yml file.
| @@ -1,4 +1,4 @@ | |||
| [bdist_rpm] | |||
There was a problem hiding this comment.
We use fpm to generate the RPM and I don't think bdist_rpm is used anymore.
I'd remove that setup.cfg file.
| from distutils.command.build_py import build_py as _build_py | ||
| from distutils.command.install_data import install_data as _install_data | ||
| from distutils.core import setup |
There was a problem hiding this comment.
distutils is deprecated and will be removed in Python 3.12: https://docs.python.org/3/library/distutils.html
setup should be imported from setuptools.
I also find all the extra things done in this setup.py quite hacky...
| description='A collection of reusable Taurus widgets', | ||
| packages=packages, | ||
| package_dir={'maxwidgets': 'src'}, | ||
| data_files=[('/etc/profile.d', [env_script])], |
There was a problem hiding this comment.
I really don't think a python package should try to install something under /etc/profile.d.
This isn't gonna work if you install the package in a virtualenv.
It only works when using a RPM. That should be done in the RPM, not python package.
Plus I don't think setting TAURUSQTDESIGNERPATH is the proper way to add widgets to taurus today.
See https://www.taurus-scada.org/devel/plugins.html and https://gitlab.com/taurus-org/taurus_pyqtgraph as an example.
Update lib-maxiv-maxwidgets to be compatible with Python 3.6, Taurus 4.7 and PyQt 5.