Write default attr values

[HEnquist]

If a controller is deployed with sardanadsconfig the default values of attributes are not written to the database. Normally this is done by the defctrl or defelem macros. Depending on the implementation of an affected controller this may or may not be a problem, but it can lead to strange and annoying errors. This PR adds a check when the Pool starts to write any missing default value after each device is started.

[amilan]

Hi @HEnquist, thanks for the PR!
I think it's a nice addition.
I can only suggest a couple of things. Instead of merging this branch to the master branch, it's better if the merge points to the develop branch, because the master branch is only used for the creations of new releases and it stays stable.
The develop branch is the one used to add new features that will be included in the next release.

The second thing depends on how we want to proceed, because we have two options: doing the PR against the develop branch in our fork and after that, create a new PR to the upstream repository, or skip this step in between and do the PR directly to the develop branch in the upstream repository.

I think I prefer the second option because it remove one step in between, but let me know your opinion and we can do one or the other.

Cheers,
Antonio.

[HEnquist]

Hi @amilan and thanks for reviewing!
I agree with you that the second option is better. The only reason I pointed it to master was that I had some trouble getting develop to run in my environment, and I was lazy so I just went with master instead. I'll rebase this on develop. Should I then make a PR to the official sardana repo?
Cheers,
Henrik

[amilan]

Hi again,

It will be great if you could make the PR directly to the upstream repo, but if you feel more comfortable doing it here, I can try to redirect it later.

Anyway, thanks again for the good job!!

[HEnquist]

Done! New PR here: sardana-org#1236