This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
Rework plotting #41
Open
Rework plotting #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is finally my attempt to improve the internal logic of the plotting. It's taken far too long and I have no excuse apart from that I moved to a new apartment and then there was christmas... :P
The changes on server side are small, mostly to render each attribute as a separate image.
The changes on the client side are larger, since now the image must be composed by the client. This makes for a bit more complexity, so I'm still not sure it makes sense. But I think it seems to work pretty well, although there are probably a few places that could use some performance improvements.
I added some simple functionality to change the color of an attribute (click the color square next to the attribute name) and to change the "width" of the selected attributes to make them stand out a bit. This is mostly a demonstration of the functionality, there's probably a better way to do it.
Please have a look! I think it's basically complete, but not well tested and should be cleaned up, but I wanted to get some feedback first. Hopefully I haven't broken too many other things...