Skip to content
This repository has been archived by the owner on Mar 18, 2021. It is now read-only.

Fix: time range on plot #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gandorm
Copy link

@gandorm gandorm commented Dec 31, 2020

No description provided.

@johanfforsberg
Copy link
Contributor

I think this change makes sense. Unfortunately it now conflicts with master since the plot stuff was reverted to use D3 v3 instead of v5. Could you update your changes to work with the new master?

@gandorm
Copy link
Author

gandorm commented Jan 18, 2021

Should be fine now! :)

@johanfforsberg
Copy link
Contributor

Yes, thanks! Unfortunately, when testing this we found that there are some issues, and they are probably the reason why we haven't done this earlier :)

Basically, the zoom limits are relative to the initial zoom. This is fine when loading the app from scratch, but if you open with an URL that sets the starting view range, it behaves badly. I don't know how to handle this, if you have an idea for a general solution it would be great, but for otherwise we can live without this for now. The viewer is currently in "maintenance mode" where we only do important fixes, while we figure out how to do when we move from cassandra to timescaledb.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants