[pull] release/9.1 from sillsdev:release/9.1 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Change-Id: I71e23e2562607cfc011bb8f184521610aa81223b
This adds the basic table data, without styling. Styling will be added in a separate change. Tables cannot be added to a paragraph, they need to be added directly to a Body. So, the majority of this change was to not create paragraphs until the end of the process; when we are in AddEntryData(). What previously was a single paragraph for the Entry, could now be multiple paragraphs if there are one or more tables not at the end of the Entry. Change-Id: I4923a87c014c2c4f51159d37d22404fceb64e5f9
* Modelled after the git project whitespace checker * Adds annotations for any whitespace issues discovered Change-Id: I7cb38bcb9b632ef73b483207f1ecc7619db653b8
- Remove unneeded TextDirection property. - Create Writing System styles so that they are based on styles that they should inherit from.
This adds support for when a style is applied to a specific cell or when different styles are applied to different pieces of the text in a cell. Note: The changes in SetRunStyle() also add support for styles that are applied to all or a portion of the text in other fields (notes, custom fields …).
Add the following table styles: - Add bold for column headers. - Add support for column spanning. - Support left, center, and right cell alignment. - Center the table title so that it spans all table columns. Change-Id: I47f40a9ff7713ceba97d00623e5669b2576237db
* Resolves LT-20228, users were confused by the cloud-api in the url and showing www makes it more clear what they should type
Fix the position of the unlink button when the writing system is right to left. Change-Id: I818384b8066213b570c39155137ad18ef842d10a
* Add images to word export Create image part for a word doc, create images, clone images between document fragments, and track relationship IDs of images. Export caption text. Formatting of image captions will be handled separately. * Cleanup word fragment writer dispose
- Fixes styles not linking with the style sheet in Microsoft Word. - Fixes styles not appearing in LibreOffice. Change-Id: I433acde125f638f963b35bcbb9b92b319062cb9a
- Specify background color using the fill property instead of color property of a shading object.
* LT-21708 Add image and caption textframes to word export - Reconfigure images to be inline instead of anchored. (Textframes require inline images; textboxes require anchored.) - Clean up cloning of image runs. - Create a global paragraph style to use for textframes. - Link textframe style to images and their captions and ensure image and associated caption are added to the same textframe. - Ensure Word does not merge adjacent images into the same textframe. This requires adding an empty paragraph between the image textframes, otherwise Word will automatically merge them into a single textframe that can't be split.
* LT-21761 & LT-21674: Handle Before, Between, After and more Handle Before, Between, After, and DisplayInSeparateParagraphs. Remaining tasks: - Tables still need indenting. - The first line after a table is shifted to the left. A new ‘continuation’ style is needed when we start a new paragraph. - Before, Between, and After might need to use a different style.
* Dispose and recreate the FocusBoxController if the writing system has changed
- Add based on property when generating styles from LCM stylesheet that have based on specified in FLEx. (LT-21769) - Edit styleDictionary to store individual styles instead of groups of styles. - Revise AddStyles so it adds each style one time only, using the stylenames instead of css classes as the dictionary keys. NOTE: In the Word export, the style dictionary should save each style individually rather than a collection of styles associated with a given css class. Otherwise, any given style may be added to the styles xml multiple times, once for each css class using that style. Remaining task: - Homograph-Number style is still being duplicated. It is handled in a different function and requires its own fix.
…er (#34) * Add NUnit3TestAdapter nuget package to our build * Use the adapter in the ITextTests project Co-authored-by: name <[email protected]>
* LT-21761: Add Table indenting and right justification Use the table parent as the basis. Change-Id: I9e49a9570c7c9d09696e1bb4c4ba22636e5cb1af
* Change to liblcm beta0089 * Add sorted list of choices based on prioritization from liblcm
Change-Id: I3c558a1a9337dfa2bf11ae21133fb49df2461f14
* LT-21761: Fix indenting for the first line after a Table The first line of an entry typically uses FirstLineIndent to indented to the left. When we have multiple paragraphs for an entry (because the entry contains Tables or Pictures) then we do not want the line following the Table or Picture to also be indented to the left. We now create a ‘continuation’ style for paragraphs following a table or picture. It is the same as the original style except it does not use FirstLineIndent.
- When starting a run, add a writing system style if the run has a WS specified. - If the run should have an additional style associated with it, replace the writing system style with a link to the writing system specific version of the additional style. - Use RunFonts object instead of Font object to specify fonts for character styles in word
Add a new attribute to analysis in the export when they are guesses not yet accepted by the user --------- Co-authored-by: Jason Naylor <[email protected]>
- Comment out handling of borders in Word Export Borders do not currently display in FLEx. But once a border is added to a style in FLEx, deselecting the border does not actually remove the border object from the FLEx style. This means if a border has ever been added in FLEx, it will still exist in the configuration node and be added in the word export. Until this is fixed, we should disable borders in the word export.
Fixed the problem with the continuation style being written to paragraphs containing images/captions (instead of the textframe style being written). Also, to prevent the problem with the paragraph following the image/caption from using the textframe style, we now base the continuation style on the first paragraph instead of the last.
References to styles in the xhtml were not matching up with the correct style names in the css. - In the Json generator we were not using the _styleDictionary to generate the css. Instead we were re-generating the css from the configuration. Now use the _styleDictionary to generate the css. - In the Json generator there were two _styleDictionaries being used. They were filled at different times and could have different values because of unique name generation. Now use one _styleDictionary. - In many situations we were still generating styles with unique names when an existing style was identical. Changed the code to re-use existing styles that had unique names. (This change was not necessary to fix the problems described in this defect but resulted in a substantial size reduction in the css file size. The Jii-entries project that is attached to the defect, and the Sena 3 project both result in a css file that is less than 10% of the old size.) Change-Id: I457674ca44b37ed966cb1d8995011a0a19df4cca
Add a lock to GetBestUniqueNameForNode() to protect against potential additional callers. Currently the only caller already established a lock. Change-Id: Id8721fd2982c5e62c4aa8ffb22e4d3d2e2ac2e76
Change-Id: I737e73956a413561a338738050f847316f6e3089
* Fix LT-21999: Improve saving of parser test reports * Fix button position * Move button to bottom of window --------- Co-authored-by: Jake Oliver <[email protected]>
- In Word 2019, a vertical offset must be specified in order for image textframes to display beneath their associated entries. - We also lock the textframes' anchors for better behavior when users drag a textframe to a new location in Word. Change-Id: Ic8090e293f4df1d5ed35176a937f7595bb8acb72
Change-Id: I9492feb443932f3be187e7f61ac64eda235c6cd8
Co-authored-by: Jason Naylor <[email protected]>
Word does not expect the indentation direction (left/right) to be flipped for right to left output. Removed the extra code and output the same indentation direction for both LTR and RTL. This problem also existed with the single column output, but became more obvious when we switched to double column output. Change-Id: Id86359ec0524f0eca8ef3c6e4aaa176efcac5122
For right to left documents this sets every section so that the column on the right is filled first. With this change the user no longer needs to do the following steps in the Word document: In the Layout tab, click the icon at the lower right of the Page Setup section, and in the dialog that comes up, set Section direction: to Right-to-left. This is critical for RTL documents so that the first column on the page is on the right side.
Co-authored-by: Jake Oliver <[email protected]>
Co-authored-by: Jake Oliver <[email protected]>
Co-authored-by: Jake Oliver <[email protected]>
…237) * Complete work for LT-21963 * Add new build task for copying locale * Add 'zlm' to the installer --------- Co-authored-by: John Maxwell <[email protected]>
* Add unit test showing the failure in LT-22017 * LT-22017: Suppress between content inside a multirun string --------- Co-authored-by: Ariel Rorabaugh <[email protected]>
- Use .net framework 462 for palaso and chorus - For Chorus, modify the versions for the specific package names instead of everything that begins with SIL.Chorus. This prevents modifying the version of SIL.Chorus.l10ns A remaining task is to either remove the line containing "SIL.Core" version="8.1.0-beta0035" from packages.config, or modify the sed command so that it does not change this version number.
* Word Export: prevent cross-thread exception Use InvokeRequired and Invoke to re-execute the TextForReal call. Notes: - XHTML export is also calling this from a different thread but we were not seeing this error because the text string was the same as the current value so no change was made. - The exception was only happening when there were reversals and it seemed to only/mostly happen in debug builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )