chore: made clippy happy

MaxOhn · Oct 18, 2024 · 1b12d5a · 1b12d5a
1 parent 2c77ddf
commit 1b12d5a
Showing 1 changed file with 70 additions and 62 deletions.
diff --git a/src/osu/performance/mod.rs b/src/osu/performance/mod.rs
@@ -417,18 +417,17 @@ impl<'map> OsuPerformance<'map> {
 
                     for new100 in min_n100..=max_n100 {
                         let new50 = n_remaining - new100;
-                        let dist = (acc
-                            - accuracy(
-                                n_slider_ticks,
-                                n_slider_ends,
-                                n300,
-                                new100,
-                                new50,
-                                misses,
-                                max_slider_ticks,
-                                max_slider_ends,
-                            ))
-                        .abs();
+
+                        let state = NoComboState {
+                            n300,
+                            n100: new100,
+                            n50: new50,
+                            misses,
+                            n_slider_ticks,
+                            n_slider_ends,
+                        };
+
+                        let dist = (acc - accuracy(state, max_slider_ticks, max_slider_ends)).abs();
 
                         if dist < best_dist {
                             best_dist = dist;
@@ -453,18 +452,18 @@ impl<'map> OsuPerformance<'map> {
 
                     for new300 in min_n300..=max_n300 {
                         let new50 = n_remaining - new300;
-                        let curr_dist = (acc
-                            - accuracy(
-                                n_slider_ticks,
-                                n_slider_ends,
-                                new300,
-                                n100,
-                                new50,
-                                misses,
-                                max_slider_ticks,
-                                max_slider_ends,
-                            ))
-                        .abs();
+
+                        let state = NoComboState {
+                            n300: new300,
+                            n100: n100,
+                            n50: new50,
+                            misses,
+                            n_slider_ticks,
+                            n_slider_ends,
+                        };
+
+                        let curr_dist =
+                            (acc - accuracy(state, max_slider_ticks, max_slider_ends)).abs();
 
                         if curr_dist < best_dist {
                             best_dist = curr_dist;
@@ -488,18 +487,18 @@ impl<'map> OsuPerformance<'map> {
 
                     for new300 in min_n300..=max_n300 {
                         let new100 = n_remaining - new300;
-                        let curr_dist = (acc
-                            - accuracy(
-                                n_slider_ticks,
-                                n_slider_ends,
-                                new300,
-                                new100,
-                                n50,
-                                misses,
-                                max_slider_ticks,
-                                max_slider_ends,
-                            ))
-                        .abs();
+
+                        let state = NoComboState {
+                            n300: new300,
+                            n100: new100,
+                            n50: n50,
+                            misses,
+                            n_slider_ticks,
+                            n_slider_ends,
+                        };
+
+                        let curr_dist =
+                            (acc - accuracy(state, max_slider_ticks, max_slider_ends)).abs();
 
                         if curr_dist < best_dist {
                             best_dist = curr_dist;
@@ -531,18 +530,18 @@ impl<'map> OsuPerformance<'map> {
 
                         for new100 in min_n100..=max_n100 {
                             let new50 = n_remaining - new300 - new100;
-                            let curr_dist = (acc
-                                - accuracy(
-                                    n_slider_ticks,
-                                    n_slider_ends,
-                                    new300,
-                                    new100,
-                                    new50,
-                                    misses,
-                                    max_slider_ticks,
-                                    max_slider_ends,
-                                ))
-                            .abs();
+
+                            let state = NoComboState {
+                                n300: new300,
+                                n100: new100,
+                                n50: new50,
+                                misses,
+                                n_slider_ticks,
+                                n_slider_ends,
+                            };
+
+                            let curr_dist =
+                                (acc - accuracy(state, max_slider_ticks, max_slider_ends)).abs();
 
                             if curr_dist < best_dist {
                                 best_dist = curr_dist;
@@ -1012,16 +1011,25 @@ fn calculate_effective_misses(attrs: &OsuDifficultyAttributes, state: &OsuScoreS
     combo_based_miss_count.max(f64::from(state.misses))
 }
 
-fn accuracy(
-    n_slider_ticks: u32,
-    n_slider_ends: u32,
+struct NoComboState {
     n300: u32,
     n100: u32,
     n50: u32,
     misses: u32,
-    max_slider_ticks: u32,
-    max_slider_ends: u32,
-) -> f64 {
+    n_slider_ticks: u32,
+    n_slider_ends: u32,
+}
+
+fn accuracy(state: NoComboState, max_slider_ticks: u32, max_slider_ends: u32) -> f64 {
+    let NoComboState {
+        n300,
+        n100,
+        n50,
+        misses,
+        n_slider_ticks,
+        n_slider_ends,
+    } = state;
+
     if n_slider_ticks + n_slider_ends + n300 + n100 + n50 + misses == 0 {
         return 0.0;
     }
@@ -1146,16 +1154,16 @@ mod test {
                     None => n_remaining.saturating_sub(new300 + new100),
                 };
 
-                let curr_acc = accuracy(
+                let state = NoComboState {
+                    n300: new300,
+                    n100: new100,
+                    n50: new50,
+                    misses,
                     n_slider_ticks,
                     n_slider_ends,
-                    new300,
-                    new100,
-                    new50,
-                    misses,
-                    max_slider_ticks,
-                    max_slider_ends,
-                );
+                };
+
+                let curr_acc = accuracy(state, max_slider_ticks, max_slider_ends);
                 let curr_dist = (acc - curr_acc).abs();
 
                 if curr_dist < best_dist {