Pr metrics improvements #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Rodgman <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
daverodgman
force-pushed
the
pr-metrics-dr
branch
from
6366d40
to
005d39e
Compare
Signed-off-by: Dave Rodgman <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
tgonzalezorlandoarm
requested changes
Aug 10, 2023
pr-metrics/get-pr-data.py
Outdated
| @@ -38,4 +39,13 @@ | |||
| p.update() | |||
|
|
|||
| with open("pr-data.p", "wb") as f: | |||
| pickle.dump(prs, f) | |||
There was a problem hiding this comment.
I put this comment here as it does not let me put it in unchanged lines of code:
Nit: Maybe we can change r = g.get_repo("ARMMbed/mbedtls") from line 18 to r = g.get_repo("Mbed-TLS/mbedtls") ?
| @@ -86,7 +91,7 @@ def is_community(pr): | |||
| def quarter(date): | |||
| """Return a string decribing this date's quarter, for example 19q3.""" | |||
There was a problem hiding this comment.
I think this comment should be changed now?
| git_worktree_path, "visualc", "VS2010" | ||
| ) | ||
| solution_dir = glob.glob(os.path.join( | ||
| git_worktree_path, "visualc", "VS*"))[0] |
There was a problem hiding this comment.
Just in case: we are not expecting it to have more than one VS* folder, right? Otherwise this would bring a problem I think
This reverts commit 005d39e.
Signed-off-by: Dave Rodgman <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some fixes/updates to the pr-metrics scripts