Skip to content

Commit

Permalink
Specify previously missed XMM register clobbers in AES-NI asm blocks
Browse files Browse the repository at this point in the history
Noticed by Gilles Peskine

Co-authored-by: Gilles Peskine <[email protected]>
Signed-off-by: Solar Designer <[email protected]>
  • Loading branch information
solardiz and gilles-peskine-arm committed Dec 11, 2024
1 parent 0abc1ce commit 4393dff
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tf-psa-crypto/drivers/builtin/src/aesni.c
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ static void aesni_setkey_enc_128(unsigned char *rk,
AESKEYGENA(xmm0_xmm1, "0x36") "call 1b \n\t"
:
: "r" (rk), "r" (key)
: "memory", "cc", "0");
: "memory", "cc", "xmm0", "xmm1", "0");
}

/*
Expand Down Expand Up @@ -737,7 +737,7 @@ static void aesni_setkey_enc_192(unsigned char *rk,

:
: "r" (rk), "r" (key)
: "memory", "cc", "0");
: "memory", "cc", "xmm0", "xmm1", "xmm2", "0");
}
#endif /* !MBEDTLS_AES_ONLY_128_BIT_KEY_LENGTH */

Expand Down Expand Up @@ -805,7 +805,7 @@ static void aesni_setkey_enc_256(unsigned char *rk,
AESKEYGENA(xmm1_xmm2, "0x40") "call 1b \n\t"
:
: "r" (rk), "r" (key)
: "memory", "cc", "0");
: "memory", "cc", "xmm0", "xmm1", "xmm2", "0");
}
#endif /* !MBEDTLS_AES_ONLY_128_BIT_KEY_LENGTH */

Expand Down

0 comments on commit 4393dff

Please sign in to comment.