Add PSA interruptible export public-key get num ops API #9820
+397
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waleed-elmelegy-arm
added
DO-NOT-MERGE
needs-ci
waleed-elmelegy-arm
force-pushed
the
add-iop-export-pub-key-get-num-ops
branch
2 times, most recently
from
d96914d to
db56913
Compare
waleed-elmelegy-arm
added
needs-preceding-pr
Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
…up() Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Key type must be a key pair or public-key if not we return PSA_ERROR_INVALID_ARGUMENT. The key type must be ECC key as this is what we support for now otherwise we return PSA_ERROR_NOT_SUPPORTED. Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
The test is marked as opaque but the parameter was set to PSA_KEY_LIFETIME_VOLATILE. Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Rename it to mbedtls_psa_export_public_key_iop_t as iop stands for "interuptible operation" already. Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
…APIs Signed-off-by: Waleed Elmelegy <[email protected]>
The test is supposed to be an opaque key test but the testing function does not support specifying an opaque driver. Signed-off-by: Waleed Elmelegy <[email protected]>
* Improve wording of comments. * Zeroize buffer before doing iop testing to avoid comparing with previous values in case they are not overwritten. * Remove redundant testing. Signed-off-by: Waleed Elmelegy <[email protected]>
…um_ops() API Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Rename interruptible_key_agreement_get_min_num_ops() testing helper function to interruptible_operations_get_min_num_ops() since it's values are not only specefic to key agreement but to any resartable ecp operation. Also add different key sizes and rounding up for keys where there are no data available. Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
waleed-elmelegy-arm
force-pushed
the
add-iop-export-pub-key-get-num-ops
branch
from
53e7ad2 to
ef5c8a9
Compare
paul-elliott-arm
added
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #9649
Add PSA interruptible export public-key get num ops API
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.