Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getName() is ignored on blocks that do not have an item #628

Open
mikerooni opened this issue Dec 3, 2023 · 0 comments
Open

getName() is ignored on blocks that do not have an item #628

mikerooni opened this issue Dec 3, 2023 · 0 comments

Comments

@mikerooni
Copy link

mikerooni commented Dec 3, 2023 •
edited
Loading

When looking at a block that doesn't have an item associated with it, TOP is calling getDescriptionId() on it to resolve the displayname.

However, it should call getName() instead, so that blocks are able to override their displayname dynamically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikerooni