Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize build script #550

Open
wants to merge 1 commit into
base: 1.18
Choose a base branch
from
Open

Conversation

DBotThePony
Copy link

@DBotThePony DBotThePony commented Apr 6, 2022

Name properly a lot of stuff
Change mod version to match exact minecraft version
Assemble deobfuscated (dev version) jar
Assemble sources jar (for IDE)
Do not include forgegradle mapped dependencies
Change group to mcjty
Remove jcenter since it is deprecated
Use not deprecated archive classifier

Fixes #548

Name properly a lot of stuff
Change mod version to match exact minecraft version
Assemble deobfuscated (dev version) jar
Assemble sources jar (for IDE)
Do not include forgegradle mapped dependencies
Change group to mcjty
Remove jcenter since it is deprecated
Use not deprecated archive classifier
@DBotThePony
Copy link
Author

Result:
idea64_hmXRJHGW1R
idea64_eMUs4yXpPf
idea64_47BdavEpG4

No fg.deobf, no transitive dependency override, IDE shows all the comments you left in your files.

from(sourceSets.main.output) {
include "mcjty/theoneprobe/api/**"
}
}

task sourceJar(type: Jar) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use java.withSourcesJar()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants