Fixes suggested by "cppcheck" static code analysis tool

McStasMcXtrace · Feb 24, 2024 · c733cca · c733cca
1 parent 02916f5
commit c733cca
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/mcstas-comps/samples/PowderN.comp b/mcstas-comps/samples/PowderN.comp
@@ -332,7 +332,10 @@ struct line_info_struct
       ret = system(cmd);
     }
 
-    if (ret == -1 || ret == 127) return(NULL);
+    if (ret == -1 || ret == 127) {
+      free(OUTFILE);
+      return(NULL);
+    }
 
     // test if the result file has been created
     FILE *file = fopen(OUTFILE,"r");
@@ -343,6 +346,7 @@ struct line_info_struct
     printf ("%s\n",cmd);
     );
     fflush(NULL);
+    fclose(file);
     return(OUTFILE);
   } // cif2hkl
 #endif

diff --git a/mcstas-comps/samples/Single_crystal.comp b/mcstas-comps/samples/Single_crystal.comp
@@ -437,7 +437,10 @@ double tau;                 /* Length of (tau_x, tau_y, tau_z) */
       ret = system(cmd);
     }
 
-    if (ret == -1 || ret == 127) return(NULL);
+    if (ret == -1 || ret == 127) {
+      free(OUTFILE);
+      return(NULL);
+    }
 
     // test if the result file has been created
     FILE *file = fopen(OUTFILE,"r");
@@ -448,6 +451,7 @@ double tau;                 /* Length of (tau_x, tau_y, tau_z) */
     printf ("%s\n",cmd);
     );
     fflush(NULL);
+    fclose(file);
     return(OUTFILE);
   } // cif2hkl
 #endif