Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to Multi Loader for Fabric Support #47

Merged
merged 65 commits into from
Oct 24, 2024

Conversation

MeAlam1
Copy link
Owner

@MeAlam1 MeAlam1 commented Sep 18, 2024

Description

Refactored the entire code to the Multi-Loader Template for Fabric Support. I have also Optimized the Variant Loader by adding Folder Looping and Added a custom Logging + a bunch of Util Classes.

Changes

  • Util Classes: Added various Utils Classes
  • Multi-Loader Template: Refactored the entire code to the Multi-Loader Template for Fabric Support.
  • Folder Loop: In stead of Specifying each JSON File, you can now Loop thru a folder to obtain all JSONs for the Variant Loader
  • Custom Logging: Added a Custom Logging System to improve the way of Debugging.
  • Mixin: Created a Mixin which minimizes the amount of methods a Developer needs to add from 6 to 3.
  • Comments: Went through all the comments and improved the Comments to ensure understandability and readability.
  • Workflow: Improved the Workflow(CI.yml) to support Fabric too.

Type of Change

  • Bug fix
  • New feature
  • Documentation update

Checklist

  • My code follows the style guidelines of this project. Contributing
  • I have performed a self-review of my own code.
  • I have commented my code following the guidelines. Contributing
  • My changes generate no new warnings.

Related Issues

* Only isChunkLoaded is broken
* Still Need to Update Comments
* And improved Case Converter
* Fixed all Comments
* Need to go thru all Files Fixing the Logging and Comments
Lowered the Files the Mod Owners need to use to create the Variant Loader
@MeAlam1 MeAlam1 added NeoForge Mod Loader Forge Fabric Mod Loader labels Oct 7, 2024
@MeAlam1 MeAlam1 marked this pull request as ready for review October 24, 2024 11:22
@MeAlam1 MeAlam1 merged commit b6ddc33 into MeAlam1:1.21 Oct 24, 2024
1 check passed
@MeAlam1 MeAlam1 deleted the 1.21 branch October 24, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Minecraft Version Enhancement New feature or request Fabric Mod Loader NeoForge Mod Loader
Projects
None yet
1 participant