Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to Multi Loader for Fabric Support #55

Merged
merged 52 commits into from
Oct 24, 2024
Merged

Conversion to Multi Loader for Fabric Support #55

merged 52 commits into from
Oct 24, 2024

Conversation

MeAlam1
Copy link
Owner

@MeAlam1 MeAlam1 commented Oct 14, 2024

Description

Refactored the entire code to the Multi-Loader Template for Fabric Support. I have also Optimized the Variant Loader by adding Folder Looping and Added a custom Logging + a bunch of Util Classes.

Changes

  • Util Classes: Added various Utils Classes
  • Multi-Loader Template: Refactored the entire code to the Multi-Loader Template for Fabric Support.
  • Folder Loop: In stead of Specifying each JSON File, you can now Loop thru a folder to obtain all JSONs for the Variant Loader
  • Custom Logging: Added a Custom Logging System to improve the way of Debugging.
  • Mixin: Created a Mixin which minimizes the amount of methods a Developer needs to add from 6 to 3.
  • Comments: Went through all the comments and improved the Comments to ensure understandability and readability.
  • Workflow: Improved the Workflow(CI.yml) to support Fabric too.

Type of Change

  • Bug fix
  • New feature
  • Documentation update

Checklist

  • My code follows the style guidelines of this project. Contributing
  • I have performed a self-review of my own code.
  • I have commented my code following the guidelines. Contributing
  • My changes generate no new warnings.

Related Issues

MeAlam1 added 30 commits August 17, 2024 18:47
* Created an IVariantEntityBase to ensure all important code is encapsulated
* Authored all code
* This Minimizes the Code that the Mod Owners need to write!
* need to reload twice cause the Loading of the Variants happen before the DataPacks get loaded ._.
* Only need to recomment some stuff
* Then we can start Porting
@MeAlam1 MeAlam1 changed the title 1.20 Conversion to Multi Loader for Fabric Support Oct 14, 2024
@MeAlam1 MeAlam1 added Enhancement New feature or request 1.20 NeoForge Mod Loader Fabric Mod Loader labels Oct 14, 2024
@MeAlam1 MeAlam1 self-assigned this Oct 14, 2024
@MeAlam1 MeAlam1 marked this pull request as ready for review October 24, 2024 16:00
Co-Authored-By: Bluedude <[email protected]>
@MeAlam1 MeAlam1 merged commit d1fef12 into MeAlam1:1.20 Oct 24, 2024
1 check passed
@MeAlam1 MeAlam1 deleted the 1.20 branch October 24, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Fabric Mod Loader NeoForge Mod Loader
Projects
None yet
1 participant