Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can now Modify the Markdown Prefix and Suffix of Existing Markdown + Optimized the way Markdown is being Applied. #68

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

MeAlam1
Copy link
Owner

@MeAlam1 MeAlam1 commented Nov 21, 2024

Description

Fixed Fabric Markdown not being Applied

Added

  • Users can now modify the Prefix/Suffix of the Markdown.
  • Users can now check if a specific Markdown is enabled.
  • adding \ in front of the markdown will cancel it out.
    • ex. \**bold** will send **bold** in stead of bold.

Changed

  • If your message between the Prefix and the Suffix is empty, it will not delete the Prefix/Suffix.
    • Before if you typed ** without anything else, it would delete the ** because the code assumed that it was applying Italic Styling.

Changes

  • Change 1: If your message between the Prefix and the Suffix is empty, it will not delete the Prefix/Suffix.
  • Change 2: Users can now check if a specific Markdown is enabled.
  • Change 3: Adding \ in front of the markdown will cancel it out.
  • Change 4: Users can now modify the Prefix/Suffix of the Markdown.

How has this been tested?

  • Use the Methods to modify the prefix/suffix
  • Start Minecraft
  • Send a Message using the old Prefix/Suffix
  • Send a Message with \ in front.
  • Send the Prefix/Suffix without anything in between.

Type of Change

  • Bug fix
  • New feature
  • Documentation update

Checklist

  • My code follows the style guidelines of this project. Contributing
  • I have performed a self-review of my own code.
  • I have commented my code following the guidelines. Contributing
  • My changes generate no new warnings.

Related Issues

Added
Users can now modify the Prefix/Suffix of the Markdown. (FOR BOLD ONLY)
Users can now check if a specific Markdown is enabled
adding \ in front of the markdown will cancel it out
ex. \**bold** will send **bold** in stead of bold.

Changed
If your message between the Prefix and the Suffix is empty, it will not delete the Prefix/Suffix.
Before if you typed ** without anything else, it would delete the ** because the code assumed that it was applying Italic Styling.
@MeAlam1 MeAlam1 self-assigned this Nov 21, 2024
@MeAlam1 MeAlam1 marked this pull request as ready for review November 21, 2024 13:29
@MeAlam1 MeAlam1 merged commit 15b8a69 into 1.21 Nov 21, 2024
1 check passed
@MeAlam1 MeAlam1 deleted the Markdown-Prefix/Suffix branch November 21, 2024 13:30
@MeAlam1 MeAlam1 added this to the 2.0.0 milestone Nov 24, 2024
@MeAlam1 MeAlam1 added Bug Something isn't working Enhancement New feature or request 1.21 Minecraft Version NeoForge Mod Loader Fabric Mod Loader labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Minecraft Version Bug Something isn't working Enhancement New feature or request Fabric Mod Loader NeoForge Mod Loader
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant