Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Remove VSAC Cred Timeout #2174

Merged

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Sep 14, 2023

Removing the VSAC TGT timeout check from the import dialog.

With the removal of the TGT, VSAC Creds no longer expire, thus making the timeout unnecessary.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR:
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary ( see internal wiki )
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner September 14, 2023 20:34
@jkotanchik-SB jkotanchik-SB self-assigned this Sep 14, 2023
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-6046-update-vsac-connection-fhir branch from d078e3c to fb9d80b Compare September 14, 2023 20:36
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2174 (fb9d80b) into bonnie-on-fhir (da9aaf2) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           bonnie-on-fhir    #2174      +/-   ##
==================================================
+ Coverage           70.85%   70.87%   +0.01%     
==================================================
  Files                 140      140              
  Lines                8351     8349       -2     
  Branches             1270     1270              
==================================================
  Hits                 5917     5917              
+ Misses               1830     1828       -2     
  Partials              604      604              
Files Changed Coverage Δ
...ts/javascripts/views/import_measure_view.js.coffee 76.28% <ø> (+0.96%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da9aaf2...fb9d80b. Read the comment docs.

@jkotanchik-SB jkotanchik-SB merged commit ed833a7 into bonnie-on-fhir Sep 14, 2023
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-6046-update-vsac-connection-fhir branch September 14, 2023 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants