Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed case-sensitivity of repo names #120

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

k----n
Copy link
Contributor

@k----n k----n commented Jan 26, 2020

Fixes #112

@stuartlangridge
Copy link
Collaborator

Hm. This is obviously a bug and obviously needs fixing, but I'm not sure I like this way of fixing it. limit.value is indeed used for the output filename, but it's also actually passed into a widget; I don't think it's a good idea to lie to a widget about which repository it's being run for (even though widgets aren't meant to differentiate their behaviour based on that). Since we know that we want everything smashed to lowercase, I think it might be better to either set limit.title (which is already used to override output filenames, and isn't looked at by widgets) or to explicitly smash case on outputFile in assembleDashboard, rather than setting the repo name to be potentially (case-)different from the actual repo name before passing it into a widget at all.

@k----n
Copy link
Contributor Author

k----n commented Jan 26, 2020

I updated the PR to lowercase slugs instead of modifying limit.value.

lib/dashboards.js Outdated Show resolved Hide resolved
@jeremy-lq
Copy link
Collaborator

@stuartlangridge Happy with the updated PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case Sensitivity
3 participants