Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull ghcrawler via submodules rather than individual clones #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joedborg
Copy link
Contributor

Makes the install procedure a little more smooth by using submodules, rather than individual clones of dependencies.

@stuartlangridge
Copy link
Collaborator

I'm not sure about this. I grant it makes it easier to pull and develop on the whole lot, but makedash doesn't actually need to be run in the same place as ghcrawler, and it's quite useful to keep that separation. For production deployment, the long-term plan is to provide a docker image, probably (this is still under discussion, and thoughts are welcomed). I don't really want to tie pulling all the ghcrawler stuff to pulling Measure itself. @jeremy-lq do you have thoughts?

@joedborg
Copy link
Contributor Author

joedborg commented Mar 21, 2018

Yeah i totally agree re. "proper" deployment. My thought there would be that you just don't then init the submodules, but you're definitely still pulling more than needed in that case (the submodule definitions). It's just that for someone spinning it up locally to try out, it's less things to worry about. Also, the possible need to pin ghcrawler to a commit if needed in the future.

Once I've got a stack running and collecting data locally, that aim is to get it running in Kubernetes (the manifests of which, I'll obviously share).

@jeremy-lq
Copy link
Collaborator

Given the points made by @stuartlangridge along with the fact that we need to figure our a longer term strategy for supporting sources beyond GitHub, it may make sense to hold off on merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants