-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new PhotonStructDecoder #181
Conversation
f6c9a59
to
792dbfa
Compare
I can't drag and drop Translation/Transform3ds onto the field, but it seems like all other decoding works. the bytes consumed member also needs to be trimmed off. |
752c9b8
to
e32ca1b
Compare
This should be like 90% of the way to feature complete, but I haven't had a chance to go through and clean-up code yet. |
I updated to the latest commit on |
I don't think there are any blocking features missing. I did want to add schema hash checking, but if I'm getting the schema UUID straight from the source already I don't see a reason to double verify it. I'd like to test once more with photon beta 1 before merging out of paranoia then I'm good to go (I'll be out at work for the next 10 hours fya), or we can just send it as is. Thank you for cleaning this up! |
No problem, I'm not planning to release anything until later tonight anyway. |
Works for me in test mode here. Seeeeennnnnndddd it |
Closes #181
Still TODO:
float64 x;
anddouble x;
hash to the same thingIt's not pretty, but for an MVP it's not bad
#181