-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LinearProfile for flywheels #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use LinearProfile for flywheels
Use LinearProfile for flywheels
Closed
jwbonner
requested changes
Feb 15, 2024
src/main/java/org/littletonrobotics/frc2024/subsystems/flywheels/Flywheels.java
Outdated
Show resolved
Hide resolved
src/main/java/org/littletonrobotics/frc2024/subsystems/flywheels/Flywheels.java
Show resolved
Hide resolved
src/main/java/org/littletonrobotics/frc2024/subsystems/flywheels/Flywheels.java
Outdated
Show resolved
Hide resolved
Check if at setpoint, not working when checking if equal within 1e-3, but works when checking withing 5 rpm
jwbonner
approved these changes
Feb 16, 2024
jwbonner
previously requested changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix issue with epsilon and idle mode with testing in sim (as discussed)
atGoal checks for setpoint equal to goal
camearle20
previously approved these changes
Feb 17, 2024
camearle20
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to using a linear profile to track setpoint and monitor check if flywheels are at the goal rpm. Tuned the sim gains to rev in ~1 sec.