Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LinearProfile for flywheels #17

Merged
merged 7 commits into from
Feb 17, 2024
Merged

Conversation

suryatho
Copy link
Contributor

Switched to using a linear profile to track setpoint and monitor check if flywheels are at the goal rpm. Tuned the sim gains to rev in ~1 sec.

Use LinearProfile for flywheels
Use LinearProfile for flywheels
@suryatho suryatho linked an issue Feb 15, 2024 that may be closed by this pull request
Check if at setpoint, not working when checking if equal within 1e-3, but works when checking withing 5 rpm
Copy link
Member

@jwbonner jwbonner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix issue with epsilon and idle mode with testing in sim (as discussed)

atGoal checks for setpoint equal to goal
camearle20
camearle20 previously approved these changes Feb 17, 2024
@camearle20 camearle20 merged commit 0e74252 into main Feb 17, 2024
2 checks passed
@camearle20 camearle20 deleted the feature-profile-flywheel-speed branch February 17, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile flywheel speed
3 participants