-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Application]: add command to container and sidecars and fix security context (again) #164
Conversation
🏆 No vulnerabilities found |
Maybe it makes sense to add a test as well? |
Question: does this overrides the container defaults?
|
please add a reference to the chart in the PR title, similar to Or use conventional commits, for example |
+1 |
only if given an non-empty list, I would assume. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I have a few more nitpicks
4fa0719
to
5aacf7b
Compare
…rity-context behavior
We trapped into helm/helm#5238 with the merge of default security context with specific ones in sidecar or initcontainer.
objects seem to be merged by using the
or
operation - effectively makingtrue
always the result for bool properties.with this change, behavior changes, but as it was already wrong in the past it just can get better.