Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(application) add CronJob capability #173

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

knabben-mms
Copy link
Contributor

No description provided.

@knabben-mms knabben-mms requested a review from a team as a code owner December 10, 2024 09:23
@technolinator-sbom-as-a-service
Copy link

technolinator-sbom-as-a-service bot commented Dec 10, 2024

🏆 No vulnerabilities found

heubeck
heubeck previously approved these changes Dec 10, 2024
@stuebingerb
Copy link
Contributor

stuebingerb commented Dec 10, 2024

How is this related to the existing metronome? Does it replace that chart? Why would someone use this over the other? Can we have some documentation?

@stuebingerb
Copy link
Contributor

stuebingerb commented Dec 10, 2024

Also, with the recent modifications I doubt that this is still a "Generic application chart with common requirements of a typical workload.".

Maybe we want to restructure the charts? At least from Proco side I am considering moving away from the application chart because I don't need any of those additions and they unnecessarily increase the complexity and risk of failure.

@heubeck
Copy link
Member

heubeck commented Dec 10, 2024

How is this related to the existing metronome? Does it replace that chart? Why would someone use this over the other? Can we have some documentation?

The metronom stays a specialized chart for triggering arbitrary http endpoints.

This change is about being able to run also complex jobs, including volume mounts, init containers and setup phases - we decided to not build an own chart, cause the requirements of the use-case that triggered that change requires most of the features already built in here.

@heubeck
Copy link
Member

heubeck commented Dec 10, 2024

Also, with the recent modifications I doubt that this is still a "Generic application chart with common requirements of a typical workload.".

Maybe we want to restructure the charts? At least from Proco side I am considering moving away from the application chart because I don't need any of those additions and they unnecessarily increase the complexity and risk of failure.

Yes, we reached a point where we should restructure and come up with a new major version also cleaning up some hassles in that chart.

I've some kiss-like charts in mind that can be combined together to composite charts using the dependency mechanism.

If you're not confident to continue to use the chat, I would appreciate to put your efforts in helping to build the next-gen chart(s) for the benefit of all.

@heubeck heubeck merged commit 5569e12 into main Dec 10, 2024
9 checks passed
@heubeck heubeck deleted the knabben-applicationcronjob branch December 10, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants