Jt redundant tables bug fix #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BranchFolder cleanup is required for the new jump table-related feature. In order for our pass to access the BranchFolding.h header file, it has been moved to the include/ directory.
A new jump table-related feature is being introduced. Pass and its related files have been renamed from NanoMipsCompressJumpTables to NanoMipsOptimizeJumpTablesas a result.
milica-lazarevic
force-pushed
the
jt-redundant-tables-bug-fix
branch
from
8c37dd1
to
fc52a9e
Compare
Some jump tables may not have any effect on the address of the following branch, making them redundant. This optimization pass identifies such tables and removes any associated code. Pass will then attempt to compress any remaining jump tables.
The NMOptimizeJumpTables pass has been registered and a relevant regression test has been added. The test will validate the removal of redundant jump tables.
milica-lazarevic
force-pushed
the
jt-redundant-tables-bug-fix
branch
from
fc52a9e
to
ef63837
Compare
cme
reviewed
Nov 28, 2023
|
@cme Ping :) |
cme
reviewed
Jan 15, 2024
milica-lazarevic
force-pushed
the
jt-redundant-tables-bug-fix
branch
from
611a845
to
05b04f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, certain jump tables may not have any effect on the address of the next branch, making them redundant. This pull request introduces a new feature related to jump tables whose job is to identify such tables and delete them, along with any associated code.